Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems on iOS devices #268

Open
2 tasks
Shifin-Malik opened this issue Dec 4, 2024 · 5 comments · May be fixed by #302
Open
2 tasks

Problems on iOS devices #268

Shifin-Malik opened this issue Dec 4, 2024 · 5 comments · May be fixed by #302
Labels
bug Something isn't working, should be fixed help wanted Extra attention is needed priority: critical Critical priority issue/pull request
Milestone
v1.0

Comments

@Shifin-Malik
Copy link
Contributor

Shifin-Malik commented Dec 4, 2024 •
edited
Loading

  • Menubar not working
  • When focusing on the text area, the keyboard does not appear, preventing text input.
@Muhammed-Rahif Muhammed-Rahif added bug Something isn't working, should be fixed priority: critical Critical priority issue/pull request labels Dec 4, 2024
@Muhammed-Rahif Muhammed-Rahif added this to the v1.0 milestone Dec 4, 2024
@Muhammed-Rahif
Copy link
Owner

@Shifin-Malik which browser is that? And it's version?

@Shifin-Malik
Copy link
Contributor Author

Shifin-Malik commented Dec 6, 2024 •
edited
Loading

@Muhammed-Rahif, I’m using Google Chrome v131.0.6778.103 & Safari. The Notepad menu bar isn’t working after the latest update.

@Muhammed-Rahif
Copy link
Owner

Muhammed-Rahif commented Dec 6, 2024 •
edited
Loading

Can you install any other browser from appstore and try on it that if it works on there? I want to confirm that its problem with iOS, not the browsers.

@Shifin-Malik
Copy link
Contributor Author

Shifin-Malik commented Dec 6, 2024 •
edited
Loading

Yes, I installed Firefox, but the menubar is still not working.

@Muhammed-Rahif Muhammed-Rahif changed the title Notpad menubar not working on iOS devices Problems on iOS devices Dec 6, 2024
@Muhammed-Rahif
Copy link
Owner

Duplicate #267.

@Muhammed-Rahif Muhammed-Rahif reopened this Dec 6, 2024
@Muhammed-Rahif Muhammed-Rahif mentioned this issue Dec 6, 2024
Closed
@Muhammed-Rahif Muhammed-Rahif added the help wanted Extra attention is needed label Dec 25, 2024
0xSalik added a commit to 0xSalik/Notpad that referenced this issue Jan 27, 2025
@0xSalik
fix: ensure onMount triggers in iOS Safari by reordering layout str…
22e1879 
…ucture

- Moved the main layout `<div>` containing `<MenuBar />` and `<EditorTabs />` outside the `isLoading` conditional block in `App.svelte`
- Prevents issues with child components' `onMount` lifecycle hooks not firing on iOS Safari
- Fixes issue Muhammed-Rahif#268: `onMount` not triggering for child components on iOS Safari
@0xSalik 0xSalik linked a pull request Jan 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working, should be fixed help wanted Extra attention is needed priority: critical Critical priority issue/pull request
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

fix: resolve onMount lifecycle issue in iOS Safari by reordering layout structure 0xSalik/Notpad
2 participants
@Muhammed-Rahif @Shifin-Malik