Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.17] Minimum required Go version in go.mod is 1.20, which isn't enough #886

Open
debarshiray opened this issue Jan 30, 2025 · 0 comments
Open

[release-1.17] Minimum required Go version in go.mod is 1.20, which isn't enough #886

debarshiray opened this issue Jan 30, 2025 · 0 comments

Comments

@debarshiray
Copy link

debarshiray commented Jan 30, 2025 •
edited
Loading

Commits fa5a4ac499d7327b and aa946f3f59c82c58 started using the slices package in Git main and release-1.17, which was only introduced in Go 1.21. Since then, main has been changed to require Go 1.22, but release-1.17 still only specifies Go 1.20 in go.mod.

It might be a good idea to make the Go version specified in go.mod match reality.
@debarshiray debarshiray mentioned this issue Jan 30, 2025
Open
debarshiray added a commit to debarshiray/toolbox that referenced this issue Jan 30, 2025
@debarshiray
build: Bump github.com/NVIDIA/nvidia-container-toolkit to 1.17.0
82e85ba 
... for CVE-2024-0134 or GHSA-7jm9-xpwx-v999.

NVIDIA Container Toolkit 1.17.0 requires Go >= 1.21, even though it's
not mentioned in its go.mod file [1].

The src/go.sum file was updated with 'go mod tidy'.

[1] NVIDIA/nvidia-container-toolkit#886

containers#1614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@debarshiray