Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [AUDIT 4.0] Evaluate ordering fix in GpuCanonicalize::gatherCommutative #12086

Open
mythrocks opened this issue Feb 8, 2025 · 0 comments
Labels
audit_4.0.0 Audit related tasks for 4.0.0 bug Something isn't working

Comments

@mythrocks
Copy link
Collaborator

This concerns SPARK-50749, which fixed an expression-ordering problem introduced in https://issues.apache.org/jira/browse/SPARK-49977.

The Spark 4.0 refactors seem to have shuffled code around, to put the affected code in CommutativeExpression. The corresponding code in spark-rapids is in GpuCanonicalize.scala.

My reading of the code is that the expression order is correct in spark-rapids, per the recursive call. The Spark 4.0 version of the code replaces the recursion with an explicit queue/stack. If SPARK-49977 is introduced into spark-rapids, we'd also need to include SPARK-50759's fix.

@mythrocks mythrocks added ? - Needs Triage Need team to review and classify audit_4.0.0 Audit related tasks for 4.0.0 bug Something isn't working labels Feb 8, 2025
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit_4.0.0 Audit related tasks for 4.0.0 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants