Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the change in PR #12092 #12126

Open
firestarman opened this issue Feb 13, 2025 · 0 comments
Open

Add tests for the change in PR #12092 #12126

firestarman opened this issue Feb 13, 2025 · 0 comments
Assignees
@firestarman
Labels
test Only impacts tests

Comments

@firestarman
Copy link
Collaborator

firestarman commented Feb 13, 2025 •
edited
Loading

This is a follow-up issue to track adding tests for the change in PR #12092. It is not easy to test that change by integration tests, and we need more time to figure out one.

To unblock the Plugin launch for customer queries, we can go with this fix without tests now(but already verified it by a customer query).
@firestarman firestarman added ? - Needs Triage Need team to review and classify bug Something isn't working labels Feb 13, 2025
@firestarman firestarman mentioned this issue Feb 13, 2025
Merged
@mattahrens mattahrens added test Only impacts tests and removed bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firestarman firestarman

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattahrens @firestarman