Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ANSI colors in log view. #21

Open
samueldr opened this issue Jul 3, 2018 · 0 comments
Open

Implement ANSI colors in log view. #21

samueldr opened this issue Jul 3, 2018 · 0 comments

Comments

@samueldr
Copy link
Member

samueldr commented Jul 3, 2018

Maybe this'll help

This isn't react-based, right.

Anyway, the biggest issues we have are these:

  • one DOM element per-line
  • line-oriented streaming
  • So, colors may need to be remembered to be re-applied inside the next DOM element

Unless this is refactored to not do one DOM element per line.

The DOM elements per line are used for:

  • Linking (through id)
  • Making a visual marker per-line

Linking shouldn't be an issue to fix, add an empty <span id="L__" /> at the start of the line. It will make highlighting full line harder, but still possible.

Peppering more DOM elements to make visual delimitations between lines may fix the issue, or even a ::before for the empty span (which could also handle making the newline)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant