From 8c5af236731611bafc2a8a6fabb83101e9fe783e Mon Sep 17 00:00:00 2001 From: Shubham Vasudeo Desai Date: Thu, 30 Jan 2025 13:35:44 -0500 Subject: [PATCH 1/2] fix Resource Leak issue --- vector/v.in.dxf/read_dxf.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/vector/v.in.dxf/read_dxf.c b/vector/v.in.dxf/read_dxf.c index 8cab43b95dd..9557021ae53 100644 --- a/vector/v.in.dxf/read_dxf.c +++ b/vector/v.in.dxf/read_dxf.c @@ -10,11 +10,19 @@ struct dxf_file *dxf_open(char *file) struct dxf_file *dxf; dxf = (struct dxf_file *)G_malloc(sizeof(struct dxf_file)); + if (!dxf) + return NULL; dxf->name = G_store(file); - if (!(dxf->fp = fopen(file, "r"))) + if (!dxf->name) { + G_free(dxf); return NULL; - + } + if (!(dxf->fp = fopen(file, "r"))) { + G_free(dxf->name); + G_free(dxf); + return NULL; + } /* get the file size */ G_fseek(dxf->fp, 0L, SEEK_END); dxf->size = G_ftell(dxf->fp); From bf97af0e2138b6f6f0b4dc49026508ae930eccce Mon Sep 17 00:00:00 2001 From: ShubhamDesai <42180509+ShubhamDesai@users.noreply.github.com> Date: Thu, 30 Jan 2025 13:59:11 -0500 Subject: [PATCH 2/2] Update vector/v.in.dxf/read_dxf.c Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- vector/v.in.dxf/read_dxf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vector/v.in.dxf/read_dxf.c b/vector/v.in.dxf/read_dxf.c index 9557021ae53..9281f778175 100644 --- a/vector/v.in.dxf/read_dxf.c +++ b/vector/v.in.dxf/read_dxf.c @@ -10,7 +10,7 @@ struct dxf_file *dxf_open(char *file) struct dxf_file *dxf; dxf = (struct dxf_file *)G_malloc(sizeof(struct dxf_file)); - if (!dxf) + if (!dxf) return NULL; dxf->name = G_store(file);