Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reutnr 404 if entity doesn't exist #357

Open
arkid15r opened this issue Jan 6, 2025 · 15 comments
Open

Reutnr 404 if entity doesn't exist #357

arkid15r opened this issue Jan 6, 2025 · 15 comments
Assignees
Labels

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Jan 6, 2025

Is your feature request related to a problem? Please describe.
For entity details pages we show "No details found" message w/o explicitly returning 404

Describe the solution you'd like
Make it throw 404 for URLs like https://nest.owasp.dev/projects/invalid

@arkid15r arkid15r added good first issue Good for newcomers frontend labels Jan 6, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Project Nest Jan 6, 2025
@arkid15r arkid15r moved this from Backlog to Todo in Project Nest Jan 6, 2025
@TenzDelek
Copy link
Collaborator

Willing to work on this cc @arkid15r

@arkid15r arkid15r moved this from Todo to In progress in Project Nest Jan 7, 2025
@shining-bluemoon-11
Copy link

well i would like to solve this @arkid15r

@TenzDelek
Copy link
Collaborator

I would like to step down from this task as I would like to finish up my two prev design card. sorry for the inconvenience, you can go ahead if you are interested cc @arkid15r and @shining-bluemoon-11

@TenzDelek TenzDelek removed their assignment Jan 7, 2025
@yashgoyal0110
Copy link
Collaborator

can i contribute to it?

@arkid15r
Copy link
Collaborator Author

arkid15r commented Jan 9, 2025

@shining-bluemoon-11 are you still working on this?

@shining-bluemoon-11
Copy link

@arkid15r

YES , I AM WORKING ON THIS
THE WORK IS IN PROGRESS

within 2 - 3 days , i wish n think i resolve this

actually , this is the beginning of my open source contribution , as a first contribution , little bit of time ; i am taking in understanding n downloading the respective prerequisites in my local machine , the problem of code is solved ,

@arkid15r I HOPE YOU UNDERSTAND

Thank you for your patience and understanding.

@arkid15r
Copy link
Collaborator Author

@shining-bluemoon-11 please submit a ready for review PR for this by the end of current iteration (
Screenshot 2025-01-09 at 5 28 34 PM

@shining-bluemoon-11
Copy link

@arkid15r 👍

@MECKTRO930
Copy link

@arkid15r i want to work on it

@yashgoyal0110
Copy link
Collaborator

@arkid15r is it resolved?

@shining-bluemoon-11
Copy link

@arkid15r , i am really sorry
12 jan ends ,
as i have not still submit PR , I'm really sorry
well i have found where the issue is in the n i have corrected it also
n i have created the required environment necessary for running this in my local machine
there i am getting {
✔ Service frontend Built 3.7s
✔ Service backend Built 3.7s
line 1: unexpected character "�" in variable name
"\xff\xfeD\x00J\x00A\x00N\x00G\x00O\x00_\x00A\x00L\x00G\x00O\x00L\x00I\x00A\x00_\x00A\x00P\x00P\x00L\x00I\x00C\x00A\x00T\x00I\x00O\x00N\x00_\x00I\x00D\x00=\x002\x00O\x00L\x00P\x00S\x00E\x00V\x00W\x008\x00R\x00\r\x00"
make: *** [Makefile:16: run] Error 15

}
i don't know why it is showing i have checked n tried everything
checked the makefile also but still not getting from where that extra unexpected character showing
i am really sorry ,
well i am still solving this , i hope n wish i will find why there was error showing

ISSUE SOLUTION :
see there are four files that need to be modified

  1. \Nest\frontend_tests_\src\pages\ProjectDetails.test.tsx
  2. \Nest\frontend_tests_\src\pages\Projects.test.tsx
  3. \Nest\frontend\src\pages\ProjectDetails.tsx
  4. \Nest\frontend\src\pages\Projects.tsx
    in these files where there is written NO PROJECT DETAILS FOUND instead should replaced with 404 NOT FOUND

really sorry for not submitting the PR on time ,
one request please , can you please give little bit of direction WHY N FROM where that unexpected character is coming
i have done everything which i know , please need your guidance here ,
and also one more days to do it (it's my first open source contribution pleaseee :)
please,
really very sorry for the inconvenience

@arkid15r
Copy link
Collaborator Author

@shining-bluemoon-11 no worries, this is not urgent and can be handled by someone else.
You can focus on setting up the dev environment. There is no way to contribute properly w/o doing it first.

It seems something is wrong with your DJANGO_ALGOLIA_APPLICATION_ID value.

@yashgoyal0110 could you take care of the issue?

@yashgoyal0110
Copy link
Collaborator

@arkid15r sure, will resolve it soon

@yashgoyal0110
Copy link
Collaborator

@arkid15r do i need to change status code in backend for invalid endpoints of all entities?

@arkid15r
Copy link
Collaborator Author

No, it's a frontend issue.
All entity pages (for example https://nest.owasp.dev/community/users/invalid) should raise 404 if requested item doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

No branches or pull requests

5 participants