-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reutnr 404 if entity doesn't exist #357
Comments
Willing to work on this cc @arkid15r |
well i would like to solve this @arkid15r |
I would like to step down from this task as I would like to finish up my two prev design card. sorry for the inconvenience, you can go ahead if you are interested cc @arkid15r and @shining-bluemoon-11 |
can i contribute to it? |
@shining-bluemoon-11 are you still working on this? |
YES , I AM WORKING ON THIS within 2 - 3 days , i wish n think i resolve this actually , this is the beginning of my open source contribution , as a first contribution , little bit of time ; i am taking in understanding n downloading the respective prerequisites in my local machine , the problem of code is solved , @arkid15r I HOPE YOU UNDERSTAND Thank you for your patience and understanding. |
@shining-bluemoon-11 please submit a ready for review PR for this by the end of current iteration ( |
@arkid15r i want to work on it |
@arkid15r is it resolved? |
@arkid15r , i am really sorry } ISSUE SOLUTION :
really sorry for not submitting the PR on time , |
@shining-bluemoon-11 no worries, this is not urgent and can be handled by someone else. It seems something is wrong with your @yashgoyal0110 could you take care of the issue? |
@arkid15r sure, will resolve it soon |
@arkid15r do i need to change status code in backend for invalid endpoints of all entities? |
No, it's a frontend issue. |
Is your feature request related to a problem? Please describe.
For entity details pages we show "No details found" message w/o explicitly returning 404
Describe the solution you'd like
Make it throw 404 for URLs like https://nest.owasp.dev/projects/invalid
The text was updated successfully, but these errors were encountered: