Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move is_indexable properties from models to models/mixins #351

Open
arkid15r opened this issue Jan 6, 2025 · 3 comments · May be fixed by #437
Open

Move is_indexable properties from models to models/mixins #351

arkid15r opened this issue Jan 6, 2025 · 3 comments · May be fixed by #437
Assignees
@bhagyashree980
Labels
backend good first issue Good for newcomers

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Jan 6, 2025

Describe the solution you'd like
The is_indexable properties should belong on mixin classes (top of the class). Let's move those methods there (e.g. from models/issue.py to models/mixins/issue.py for Issue model)
@arkid15r arkid15r added good first issue Good for newcomers backend labels Jan 6, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Project Nest Jan 6, 2025
@arkid15r arkid15r moved this from Backlog to Todo in Project Nest Jan 6, 2025
@bhagyashree980
Copy link
Collaborator

Hii @arkid15r , Please assign me this issue.

@bhagyashree980
Copy link
Collaborator

I think i can do this

@bhagyashree980
Copy link
Collaborator

I'll create a new mixin class in the models/mixins/ directory.
The is_indexable property will be moved from models/issue.py to the mixin class, ensuring it stays reusable and adheres to the single-responsibility principle.
The Issue model will then inherit from the new mixin.

@arkid15r arkid15r moved this from Todo to In progress in Project Nest Jan 6, 2025
This was referenced Jan 8, 2025
Closed
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhagyashree980 bhagyashree980

Labels
backend good first issue Good for newcomers
Projects
Project Nest
Status: In progress
Milestone
No milestone
2 participants
@arkid15r @bhagyashree980