Make edge labels legible and selectable #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The labels for data flow and trust boundary curve can not be used to select the edge - it would be very useful if they could
also the labels can be obscured by the line passing through them - this needs whitespace around the label
Description for the changelog:
flow and trust boundary labels made legible and selectable
Other info:
also applies a select box around the flow stencil and trust boundary curve stencil, for easier selection of these stencils
closes #1198
although it does not solve #1174 , this is the best we can do. If the verticex change event is used to select the data flow then the vertex no longer becomes available for change. This comes from AntV/X6 and is unlikely to change
closes #1174