Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing trip options causes a blank interface in some cases #1036

Open
devinbraun opened this issue Apr 22, 2020 · 3 comments
Open

Changing trip options causes a blank interface in some cases #1036

devinbraun opened this issue Apr 22, 2020 · 3 comments
Labels
Milestone

Comments

@devinbraun
Copy link

Summary:

Blank interface is shown when changing trip options from a successful trip plan to an unsuccessful trip plan.

Steps to reproduce:

Create a valid trip plan, then change the trip options making the trip invalid or unsuccessful, such as from TRANSIT to Rail only where Rail isn't available and OBA returns a blank screen and the interface elements are frozen/unusable

Expected behavior:

Provide a message that the trip plan is invalid as it would in any other instance when getting an invalid trip on the first try and then return the user to the form to make changes.

Device and Android version:

App Version: 2.7.0
Model: Pixel 2
OS Version: 10 / 29

Screenshots:

OBA Trip Planner Blank Screen

@barbeau barbeau added the bug label Apr 23, 2020
@barbeau barbeau added this to the v2.6 milestone Apr 23, 2020
@barbeau
Copy link
Member

barbeau commented Apr 23, 2020

@devinbraun Could provide an exact input for origin and destination where you're seeing this? Also, could you confirm you're on OBA Android v2.7.0 (via Settings->About)?

I can't seem to reproduce this on a Samsung Galaxy S8+ with Android 9 w/ v2.7.0.

In Tampa and San Diego, if I successfully plan a "Transit only" trip, and then switch to "Rail only", I get the normal "Planning not possible" UI. Here's a San Diego example:

image

@devinbraun
Copy link
Author

I'm on v2.7.0 (117)

I did a little more testing and at first, I also got the regular "planning not possible" message, but then when I tried again, it didn't work. What I found was that if the trip planning inputs where "hidden" when I changed trip preferences, I see the bug. If they are showing when I changed the inputs, I didn't experience the bug. The inputs are "hidden" when a successful trip plan shows up, and I have to pull them down to show them.

oba trip plan no trip inputs showing
OBA trip plan with trip inputs showing

@barbeau
Copy link
Member

barbeau commented Apr 23, 2020

@devinbraun Ah, ok, thanks! Yes, I can reproduce this now. Thanks for the additional info, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants