Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Settings Screen Now Updates to Dark Mode Correctly #1301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Avinash-Codes
Copy link

@Avinash-Codes Avinash-Codes commented Feb 11, 2025

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

Screen_recording_20250211_130900.webm

fixes #1300

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@amrhossamdev
Copy link
Member

Hi @Avinash-Codes Thanks for your contributions! I will review it shortly.

@amrhossamdev amrhossamdev self-requested a review February 11, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings screen does not update to dark mode when switching from light mode
3 participants