Transfer IEDs to Substation section #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyill
changed the title
|
I've deployed this to https://transpower-nz.github.io/open-scd/ so hopefully we'll find its rough edges there. |
|
The current logic shows IEDs in any substation in the same substation.
With the help of #42 we should only show the IEDs associated with a particular substation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
I would be grateful for a review and happy to make improvements.
I could not help myself and had to add the ability to press "Esc" in the middle of placement to revert to the previous position as part of this PR.
Likely additional tests of the cleanup of the
Privateelement and transfer of theesld:IEDNameelements between containers are required, nevertheless we must first see if this passes a sniff test.I expect the snapshots are not portable and will need to be regenerated in your preferred environment as usual.