Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a top-level error handler #188

Open
gjedeer opened this issue Feb 23, 2018 · 2 comments
Open

Add a top-level error handler #188

gjedeer opened this issue Feb 23, 2018 · 2 comments

Comments

@gjedeer
Copy link
Contributor

gjedeer commented Feb 23, 2018

OpenHantek on my device (Ubuntu 16.04, Hantek 6022BL) crashes like this:

terminate called after throwing an instance of 'std::runtime_error*'
[1]    470 abort (core dumped)  OpenHantek

Only by running gdb I can tell that it had thrown an exception in openhantek/src/docks/HorizontalDock.cpp line 140. Maybe it would be helpful for users to add a top-level error handler displaying the exception message before crashing.

@davidgraeff
Copy link
Member

The console log should be used whenever a runtime_error is thrown. But the general idea is to just get rid of the error source. The runtime_error is just a symptom for an error some layers further down.

@davidgraeff
Copy link
Member

The specific runtime_error and the cause for it was removed in the openhantek2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants