Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts deployed through Defender are duplicated in address book #87

Open
maikelordaz opened this issue Dec 3, 2024 · 3 comments
Open

Comments

@maikelordaz
Copy link

When creating an upgrade proposal using foundry scripts and defender, it adds four contracts to the address book, (see attached image) one of those contracts is the implementation added twice, the other one the proxy and the other one the multisig. I have some questions regarding this:

1- Is there a way to avoid this POST to the address book? I dont need any of it there and this make the tool unavailable for mainnet on the free trial with the three contracts quota.
2- Is there a way to propose a transaction calling any function using foundry scripts? Like pause a contract or mint some tokens

image

@ericglau
Copy link
Member

ericglau commented Dec 4, 2024

  1. Would it work for you to delete the unneeded contracts from the address book?
  2. That is the remaining part of Add support to create proposals through the OpenZeppelin Defender  #3 and isn't available at the moment. Note that you could include a function call when proposing an upgrade though.

@maikelordaz
Copy link
Author

Hey @ericglau actually no, as you see, there are four contracts, I did not have any of those in the address book, The one without name is the multisig I have configured in the approval process, the sepolia proxy is the ERC-1967 contract, the other two are the new implementation duplicated, all those are posted to the address book when I run the script with Defender.proposeUpgrade but in mainnet the script fails because it is only allowed three contracts in mainnet, if the implementation was not duplicated the mainnet script will pass. My workaround was to validate the implementation and deploy it with Upgrades.prepareUpgrade (this post the implementation only once) and do the proposal through the Defender UI.

Regarding the second point, great, I'll be waiting for that 💪🏻

@NicoMolinaOZ
Copy link

Hey @maikelordaz.
@ericglau and I could not reproduce this issue. Please let us know if you are still having this issue.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants