Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCA5 shapefile #1235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

NCA5 shapefile #1235

wants to merge 4 commits into from

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Jan 23, 2025

Address #1234

@lee1043 lee1043 requested a review from acordonez January 23, 2025 23:51
@lee1043 lee1043 marked this pull request as ready for review January 23, 2025 23:51
@lee1043 lee1043 self-assigned this Jan 23, 2025
@lee1043 lee1043 linked an issue Jan 23, 2025 that may be closed by this pull request
@lee1043
Copy link
Contributor Author

lee1043 commented Jan 23, 2025

@acordonez could you review if this would meet your need?

The shape file can be found as the following.

from pcmdi_metrics import resources
egg_pth = resources.resource_path()
import os
source_path = os.path.join(egg_pth, "nca5_regions.shp")
print(source_path)
print(os.path.isfile(source_path))

@lee1043 lee1043 changed the title Nca5 shapefile NCA5 shapefile Jan 23, 2025
@acordonez
Copy link
Collaborator

@lee1043 I just need to get Paul to confirm if this is the exact shapefile we want, but otherwise this has worked great! I can get the shapefile path and load the file into a geopandas dataframe and regionmask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: NCA5 shape file
2 participants