Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addHtml > proper CSS inline border #1670

Open
santaclaus21 opened this issue Jul 19, 2019 · 1 comment · May be fixed by #2728
Open

addHtml > proper CSS inline border #1670

santaclaus21 opened this issue Jul 19, 2019 · 1 comment · May be fixed by #2728
Labels
Bug Report HTML
Milestone
1.4.0

Comments

@santaclaus21
Copy link

santaclaus21 commented Jul 19, 2019 •
edited
Loading

It is working:
<table style="border: 4px #FF0000 dotted;">

But it is not - this is correct W3C border syntax, additional - border width seems to be not working at all:
<table style="border: 4px dotted #FF0000;">

https://www.w3schools.com/cssref/pr_border.asp
@santaclaus21 santaclaus21 changed the title proper CSS inline border addHtml > proper CSS inline border Jul 19, 2019
@0b10011
Copy link
Contributor

0b10011 commented Aug 28, 2019

Seems that preg_match('/([0-9]+[^0-9]*)\s+(\#[a-fA-F0-9]+)\s+([a-z]+) is used to parse border, which definitely doesn't match CSS recommendation. This is also limited only to hex colors. Once #1669 is merged, I'll try to take a look at this. (Ping me if that has been merged and this isn't fixed.)

@Progi1984 Progi1984 added the HTML label Aug 22, 2024
@Progi1984 Progi1984 added this to the 1.3.0 milestone Aug 22, 2024
@Progi1984 Progi1984 modified the milestones: 1.3.0, 1.3.1 Sep 1, 2024
Azamat8405 pushed a commit to Azamat8405/PHPWord that referenced this issue Jan 23, 2025
fix: fixing issue PHPOffice#1670
949c2b5
Azamat8405 pushed a commit to Azamat8405/PHPWord that referenced this issue Jan 23, 2025
fix: fixing issue PHPOffice#1670. Some changes.
6fe7bd7
@Azamat8405 Azamat8405 linked a pull request Jan 23, 2025 that will close this issue
Open
4 tasks
Azamat8405 pushed a commit to Azamat8405/PHPWord that referenced this issue Jan 23, 2025
fix: fixing issue PHPOffice#1670. Some changes for PHP CS Fixer.
09a9dc6
Azamat8405 pushed a commit to Azamat8405/PHPWord that referenced this issue Jan 23, 2025
fix: fixing issue PHPOffice#1670. Some changes for PHP CS Fixer 2.
d4daabe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report HTML
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Proper css inline border #1670 Azamat8405/PHPWord
3 participants
@santaclaus21 @0b10011 @Progi1984