Upgrade rq 1.3.0 -> 1.5.2 #363

petlack · 2020-09-14T08:39:28Z

Fixes #362

waldner · 2020-10-03T14:49:41Z

While this fixes the original issue, I now get:

rq-dashboard    | [2020-10-03 14:47:35,257] ERROR in app: Exception on /0/data/jobs/default/failed/11/1.json [GET]
rq-dashboard    | Traceback (most recent call last):
rq-dashboard    |   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 2447, in wsgi_app
rq-dashboard    |     response = self.full_dispatch_request()
rq-dashboard    |   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1952, in full_dispatch_request
rq-dashboard    |     rv = self.handle_user_exception(e)
rq-dashboard    |   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1821, in handle_user_exception
rq-dashboard    |     reraise(exc_type, exc_value, tb)
rq-dashboard    |   File "/usr/local/lib/python3.8/site-packages/flask/_compat.py", line 39, in reraise
rq-dashboard    |     raise value
rq-dashboard    |   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1950, in full_dispatch_request
rq-dashboard    |     rv = self.dispatch_request()
rq-dashboard    |   File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1936, in dispatch_request
rq-dashboard    |     return self.view_functions[rule.endpoint](**req.view_args)
rq-dashboard    |   File "/rq_dashboard/web.py", line 101, in _wrapped
rq-dashboard    |     result_dict = f(*args, **kwargs)
rq-dashboard    |   File "/rq_dashboard/web.py", line 427, in list_jobs
rq-dashboard    |     total_items, jobs = get_queue_registry_jobs_count(
rq-dashboard    |   File "/rq_dashboard/web.py", line 234, in get_queue_registry_jobs_count
rq-dashboard    |     jobs = [serialize_job(job) for job in current_queue_jobs]
rq-dashboard    |   File "/rq_dashboard/web.py", line 234, in <listcomp>
rq-dashboard    |     jobs = [serialize_job(job) for job in current_queue_jobs]
rq-dashboard    |   File "/rq_dashboard/web.py", line 169, in serialize_job
rq-dashboard    |     id=job.id,
rq-dashboard    | AttributeError: 'NoneType' object has no attribute 'id'

when I try to look at failed jobs.

jmandt · 2020-10-23T12:37:55Z

@mgax @nvie would one of you guys be able to have a look at the pull request and merge it if this update of rq version is reasonable?

mgax · 2020-10-28T21:32:04Z

@mgax @nvie would one of you guys be able to have a look at the pull request and merge it if this update of rq version is reasonable?

Hey @jmandt, I haven't used rq-dashboard in years, can't help you there, sorry :)

Cybernisk · 2020-11-02T12:17:30Z

Hi, @jmandt I've got the same problem as @waldner above with rq==1.5.2 installed inside but with Finished jobs list.

Cybernisk · 2020-11-02T17:52:17Z

I guess I found the reason for the bug. RQ registries are not cleaned.
My example is that I have 29 jobs in FinishedJobRegistry, but if I count all Redis keys rq:job:* it gives me only 8.
I'm not sure, but it could be because of the old rq package I use. Seems that it was fixed in this MR. I will update all rq and rq-related packages in my project and will see how it goes.

Upgrade rq 1.3.0 -> 1.5.2

acfc056

cjlapao closed this Jun 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade rq 1.3.0 -> 1.5.2 #363

Upgrade rq 1.3.0 -> 1.5.2 #363

petlack commented Sep 14, 2020

waldner commented Oct 3, 2020

jmandt commented Oct 23, 2020

mgax commented Oct 28, 2020

Cybernisk commented Nov 2, 2020 •

edited

Loading

Cybernisk commented Nov 2, 2020

Upgrade rq 1.3.0 -> 1.5.2 #363

Upgrade rq 1.3.0 -> 1.5.2 #363

Conversation

petlack commented Sep 14, 2020

waldner commented Oct 3, 2020

jmandt commented Oct 23, 2020

mgax commented Oct 28, 2020

Cybernisk commented Nov 2, 2020 • edited Loading

Cybernisk commented Nov 2, 2020

Cybernisk commented Nov 2, 2020 •

edited

Loading