Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of digits allowed by default #43

Open
ellenaua opened this issue Apr 16, 2016 · 2 comments
Open

Number of digits allowed by default #43

ellenaua opened this issue Apr 16, 2016 · 2 comments

Comments

@ellenaua
Copy link

ellenaua commented Apr 16, 2016

When we have these two inputs on the page

<gold-cc-input auto-validate card-type="{{cardType}}"></gold-cc-input>
<gold-cc-cvc-input card-type="[[cardType]]"></gold-cc-cvc-input>

user sometimes wants to start typing from second one. But that allows only 3 digits by default (when cardType is unknown). Maybe it makes sense to allow both 3 and 4 symbols when cardType is undefined yet?

@notwaldorf
Copy link
Contributor

Yeah, that makes sense! Would you be interested in sending a PR and an unit test to add this feature?

@ellenaua
Copy link
Author

@notwaldorf PR is here #47 but please check if that's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants