-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate improved logger #718
Comments
Initial findings on pressio logging Existing levels
Proposed levelsWe really only need three configurable levels (naming tbd):
In addition to these, we need the warning/error levels:
As a note, throughout this process we should clean up the use of Work Plan
Implementation
|
we need to make sure the logger can handle the case with MPI and without MPI. another option is to print from all ranks, but i think this becomes a huge pain and not really worth it Any ideas on how to do this? can you please think of a possible solution for all this and how to go about it? |
one other thing we would need: inside the solvers, i would liek to add option of outputing the solvers info to a file directly. |
@fnrizzi Here are some thoughts on how to add the option to specify the comm and rank: Option 1: macros
Option 2: class instantiation
I think the class (option 2) might be the best approach for long-term maintenance and ability to add new features. It would require a lot of changes to Pressio/pressio source though |
Remove dependency on
sbdlog
and determine best approach at implementing a new logger.Some considerations:
The text was updated successfully, but these errors were encountered: