fixing lookup_contactbyname

[MarcMichalsky]

Hi,

the lookup_contactbyname API needs a few fixes.

Firstly, there is the deprecation of the Contact.getquick API3, which could be replaced by implementing the Contact.autocomplete API4. See #424.

Furthermore, the flaw should be fixed where the contact with the shortest search hit (Smith) receives a higher rating than the contact with the more matching search hit (John Smith). I have explained the issue here: #403

What would it cost to implement these two requirements? If necessary, we would pay for it ourselves or motivate the community to fund it.

[bjendres]

Thanks for raising/documenting this, @MarcMichalsky. Maybe we can schedule a brief call next week?

[MarcMichalsky]

Yes, let's discuss that.

[bjendres]

@MarcMichalsky You said it's working for you using Contact.autocomplete instead of Contact.getquick - could you create an actual PR for that please?

[MarcMichalsky]

I thought that was what we wanted to hire you for, not the other way around. By the way, the idea of using Contact.autocomplete actually came from you: #424 (comment)

What I fixed was the poor matching by Contact.getquick (#403), but that's now obsolete, I guess.

[bjendres]

I thought that was what we wanted to hire you for, not the other way around. By the way, the idea of using Contact.autocomplete actually came from you: #424 (comment)

Ok, right, I think I got this confused with one of the other tickets....

That's fine, but I think I'll put that in the 1.3 then.

[bjendres]

That's fine, but I think I'll put that in the 1.3 then.

Just to be clear: that doesn't mean it would take another year or so - we wanted to increase the release cycle anyway.