Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct markup for forms and pages #41

Open
jensschuppe opened this issue Apr 24, 2020 · 3 comments
Open

Use correct markup for forms and pages #41

jensschuppe opened this issue Apr 24, 2020 · 3 comments
Milestone

Comments

@jensschuppe
Copy link
Contributor

jensschuppe commented Apr 24, 2020

The templates should use correct markup structure and CSS classes for elements to be displayed correctly with the CiviCRM Core design as well as org.civicrm.shoreditch.

An example for when this fails with Shoreditch, is the form at civicrm/membership/payments:
membership_design_flaws

It should display like this:
membership_design_correct

This involves (incomplete):

  • making the page path contain civicrm/admin/ so that admin-related styles are applied (I guess those forms are not meant to be public)
  • wrapping submit buttons with <div class="crm-submit-buttons"></div>
  • adding the crm-form-submit CSS class to <input type="submit" /> elements
  • moving the .crm-submit-buttons element inside the .crm-form-block
  • replacing the crm-master-accordion-header class with crm-accordion-header
@bjendres bjendres added this to the 0.7 milestone Jun 5, 2020
@bjendres
Copy link
Member

bjendres commented Jun 5, 2020

@jensschuppe care to provide a PR?

@jensschuppe
Copy link
Contributor Author

Sure, can you confirm that one beforehand?

making the page path contain civicrm/admin/ so that admin-related styles are applied (I guess those forms are not meant to be public)

... so as to not break anything (permission-like).

@bjendres
Copy link
Member

bjendres commented Jun 8, 2020

civicrm/membership/payments is meant for users not just for admins.

@bjendres bjendres modified the milestones: 0.7, 1.0 Aug 23, 2023
@bjendres bjendres added this to the 1.1 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants