Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring mandate with yearly interval: wrong date for next collection #696

Open
fsnet opened this issue Jan 8, 2024 · 3 comments
Open

Comments

@fsnet
Copy link

fsnet commented Jan 8, 2024

Since the selectable collection days are limited to 1-28 it is not possible to configure a recurring mandate with a yearly interval and a collection day > 28.
Thus it is impossible to establish a recurring mandate with a yearly collection on (e.g.) 01-31
Is there a compelling reason for the limit?

Bildschirmfoto 2024-01-08 um 11 55 01

Bildschirmfoto 2024-01-08 um 11 59 16

@eptbertram
Copy link
Contributor

Not all month have more than 28 days.

Maybe you can use the settings on buffer days to archieve your goal?

@bjendres
Copy link
Member

bjendres commented Mar 25, 2024

Is there a compelling reason for the limit?

The "compelling reason" is simply that allowing something like "31" as a collection day would require additional logic to enable the system to still generate valid collection dates, e.g. in monthly collections. The same check would have to be done in your proposed scenario with annual collections, but then it would be able to validate this in at configuration time. And don't get me started on leap days...

Since this could be implemented in a sensible way, even though it would require quite some work and testing, I'll mark this as feature request.

@bjendres
Copy link
Member

bjendres commented Mar 25, 2024

One addition: Of course you could always implement the alter_next_collection_date hook here to implement the behaviour you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants