Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics #25

Open
Arkoniak opened this issue Mar 10, 2020 · 1 comment
Open

Add more metrics #25

Arkoniak opened this issue Mar 10, 2020 · 1 comment
Assignees
@PyDataBlog
Labels
enhancement New feature or request

Comments

@Arkoniak
Copy link
Collaborator

Currently we are implementing only SqEucledian metric, but we can add support for all other metrics in Distances in the same manner as it is done in https://github.com/JuliaStats/Distances.jl/blob/master/src/generic.jl#L45

We should check the performance of course. It may be possible to use our own implementation for SqEucledian and generic Distances implementation for all other metrics.
@Arkoniak Arkoniak added enhancement New feature or request good first issue Good for newcomers labels Mar 10, 2020
@Arkoniak Arkoniak removed the good first issue Good for newcomers label Apr 13, 2020
@PyDataBlog PyDataBlog self-assigned this Apr 13, 2020
@PyDataBlog PyDataBlog mentioned this issue May 7, 2020
Closed
3 tasks
@Arkoniak
Copy link
Collaborator Author

Arkoniak commented May 9, 2020

Yinyang and Coreset doesn't support other distance functions yet.

@Arkoniak Arkoniak reopened this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PyDataBlog PyDataBlog

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arkoniak @PyDataBlog