Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong age calculation on year change #76

Open
Pyrdacor opened this issue Nov 3, 2022 · 2 comments
Open

Wrong age calculation on year change #76

Pyrdacor opened this issue Nov 3, 2022 · 2 comments
Assignees
Labels
1.20 bug Something isn't working enhancement New feature or request game Issues related to the Amiga game
Milestone

Comments

@Pyrdacor
Copy link
Owner

Pyrdacor commented Nov 3, 2022

At offset $3A inside the Party_data.sav there is a value which stores how many years have passed since start of the game (year 978). This value obviously starts at 0.

In the original this is added to the character's age. I guess the plan was to only increase the character's age by 1 due to artificial aging and then just use this global "years passed" value to add it for all.

Unfortunately when a year passes, both values are increased by 1. So each year every character ages by 2 years.

This is hardly noticable as you have to sleep 365 times until it has any effect.

This will also kill you sooner of course. I guess the easiest way to fix it is just to remove the addition of that value and just stick to the character's age value solely. Did it in AA already.

@Pyrdacor Pyrdacor added the bug Something isn't working label Nov 3, 2022
@Pyrdacor Pyrdacor self-assigned this Nov 3, 2022
@Pyrdacor Pyrdacor added enhancement New feature or request game Issues related to the Amiga game labels Nov 3, 2022
@a1exh
Copy link

a1exh commented Nov 3, 2022

There is another age issue in Ambermoon I noticed. I don't know if you want a new bug for this? Or if it has been reported before? It is about the age of recurring characters from Amberstar.

Ambermoon I believe somewhere explains how many years have passed since Amberstar (NPC_texts.amb 004 "IT IS ONLY THANKS TO THE BROTHERHOOD THAT DREADFUL LORD TARBOS DID NOT REAPPEAR FOR THE LAST 70 YEARS").

If you add approx 70 years to the age the recurring characters were in Amberstar it does not equal the age those characters are in Ambermoon. (At least not all of them)

e.g. your Grandfather (who was the PC in Amberstar), Pelanis (who is younger now than Amberstar!), Lady Sandra, Gryban and probably others?

@Pyrdacor
Copy link
Owner Author

Pyrdacor commented Nov 3, 2022

I guess the only ones which might be old enough and might appear in Amberstar are Tar, Lebab, Dönner, Kire or Dorina.

I also noticed that. At least for Grandpa and Sandra.

@Pyrdacor Pyrdacor added this to the Release 1.18 milestone Feb 17, 2023
@Pyrdacor Pyrdacor modified the milestones: Release 1.18, Release 1.19 Apr 25, 2023
@Pyrdacor Pyrdacor added the 1.19 label Apr 25, 2023
@Pyrdacor Pyrdacor added 1.20 and removed 1.19 labels Jul 20, 2023
@Pyrdacor Pyrdacor modified the milestones: Release 1.19, Release 1.20 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 bug Something isn't working enhancement New feature or request game Issues related to the Amiga game
Projects
None yet
Development

No branches or pull requests

2 participants