-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tool belt #1349
Merged
Merged
Adding tool belt #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
cosmiccoincidence
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Waiting on gitbook doc.
cosmiccoincidence
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
doc : https://ss3d.gitbook.io/systems/containers/setting-up-a-container/custom-storage-conditions
This PR allows player to wear a toolbelt. The toolbelt can't be put on without a jumpsuit, and the jumpsuit needs a toolbelt to be put on.
PR checklist
Pictures/Videos)
Testing
Try puttin the belt in its container while not wearing a jumpsuit and while wearing one. Try removing the jumpsuit while wearing a belt and while not wearing one.
Networking checklist
Changes
Did some changes in the container script. Container now check for a bunch of custom exterior conditions, which are script implementing the IStorageCondition interface on the same game objects as the container. This allow to add custom conditions to fullfil to add and/or remove stuff from a given container.
Refactored just a bit the container script as I noticed it was a bit messy regarding which method can add or delete things from the list of items in the container and it was causing small bugs like removing the toolbelt from hand if it could not go in the waist container.
Had to remove the bodypart asset database and put everything in the item one. I realized we can't put the same asset in two different addressable groups, which is an issue for body parts since they can be viewed as items and bodyparts. The best option is to have a single addressable group called "gameObject" which just contain every game object asset we have. not implemented here but it's kind of just renaming the asset database (and fixing eventual errors in code arising from the renaming)
Known issue
TODO