Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search text remain in tilemap menu when reopen and not display search result #1383

Closed
jckling opened this issue Dec 8, 2023 · 2 comments · Fixed by #1384
Closed

Search text remain in tilemap menu when reopen and not display search result #1383

jckling opened this issue Dec 8, 2023 · 2 comments · Fixed by #1384
Labels
Bug: Confirmed Bugs that have been confirmed by another contributor. Difficulty: Good first issue 🍰 Easy tasks Tilemaps Tasks related to the tilemap system or its connectors.

Comments

@jckling
Copy link
Contributor

jckling commented Dec 8, 2023

Summary

Search text remain in tilemap menu when reopen and not display search result

Current Behavior

The search text typed in search bar does not be cleared or applied when reopen the tilemap menu

Steps to Reproduce

  1. Open the tilemap menu using b and type any text in the search bar
  2. Close and reopen the tilemap menu
bag.mp4

Expected Behavior

Clear the search text or display the search result

Possible Solution

Clear the input field when open the menu, or apply search if text not empty
@jckling jckling added the Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. label Dec 8, 2023
@cosmiccoincidence
Copy link
Member

Clear input field imo.

@cosmiccoincidence cosmiccoincidence added Difficulty: Good first issue 🍰 Easy tasks Tilemaps Tasks related to the tilemap system or its connectors. Bug: Confirmed Bugs that have been confirmed by another contributor. and removed Bug: Unconfirmed Bugs that need to be confirmed by a another contributor. labels Dec 8, 2023
@jckling
Copy link
Contributor Author

jckling commented Dec 8, 2023

I think so

@jckling jckling mentioned this issue Dec 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Confirmed Bugs that have been confirmed by another contributor. Difficulty: Good first issue 🍰 Easy tasks Tilemaps Tasks related to the tilemap system or its connectors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear input field in search bar when close the tilemap menu jckling/SS3D
3 participants
@jckling @cosmiccoincidence @iamteapot422