-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of deleted feed from Feeds list UI is delayed on iOS #4514
Comments
Does the app iterate and delete feed items one by one? I discovered that when I retried to the app hours later, the feed was indeed gone. Only thought is if the delete process is synchronous before terming the feed itself from UI. This would explain why there was no visible indication that deleting was happening. And that it eventually completed and quietly removed the feed. |
Not all, but feed above it disappeared automatically. Rest all exists at the moment. |
@jasonkarns Are you using Feedly syncing by any chance? We’ve seen issues like this with Feedly, but we don’t know yet if it’s Feedly or an issue with our Feedly sync implementation. If you’re not using Feedly, which sync system are you using? Are you on Mac or iOS? Which version of NetNewsWire? |
@brentsimmons on 6.1.8 using iCloud syncing. there were hundreds (600?) of items in the feed when i deleted the feed. The feed in question was http://feeds.feedburner.com/RyanFlorenceBlog. I re-added the feed (still under icloud). There were 1000+ unread items. Attempted delete again and got the same behavior (no error, no immediately deletion) |
I also just added the same feed under both icloud and on-my-mac using NNW on macOS. Deletion under both accounts was immediate. (The feed was visibly removed from the feed list immediately.) Additionally, I added it on my phone under the on-my-iphone account, and attempted deletion. It took almost a minute to disappear from the feeds list. So it seems the behavior is consistent across icloud and on-device, but only on iOS. (Though the delayed removal is "worse" on icloud account than on-device.) |
When NNW deletes a Feed in iCloud it has to delete all the associated Articles first in order to free up the iCloud storage used by them. It will then delete the Feed from iCloud. If all this goes well, then the Feed is removed from NNW's local storage. Things are done in this order so that if anything goes wrong with the iCloud steps that you still have a local Feed available to try to delete again. Unfortunately iCloud can be slow and this process isn't immediate. Compounding this problem is that you can't delete records using a query in iCloud. You have to fetch all the record ids first and then delete records in batches using the record ids. One enhancement might be to change the display of the Feed in the Sidebar to something else, maybe dimmed, when a delete is in progress. This would benefit the iCloud Account and any other sync Account since they also confirm the server delete before removing the Feed locally. |
👍 Or even just a message of some kind. The present behavior gives no indication that the delete request was accepted, or is in progress. The "are you sure" dialog just goes away and nothing on the screen changes. |
Ideally we’d optimistically delete it, and let the iCloud stuff happen in the background. |
On the feed list view, swiping to reveal feed options. Select delete feed. Confirm the dialog.
Then nothing happens. No error, but also the feed isn’t deleted. App has been restarted. Same behavior.
The text was updated successfully, but these errors were encountered: