Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: #898 Spinboxes Create Assets #984

Closed
fdoving opened this issue May 8, 2021 · 8 comments
Closed

Testing: #898 Spinboxes Create Assets #984

fdoving opened this issue May 8, 2021 · 8 comments

Comments

@fdoving
Copy link
Contributor

fdoving commented May 8, 2021

Post your test results as comments to this issue.

Please include release version or commit-hash used when testing.

@lorancecall
Copy link

27dec57

When reissue asset, cannot change the 'Unit'
Not sure this is originally designed this way.

@lorancecall
Copy link

lorancecall commented May 30, 2021

27dec57
image

-edited-
The alert message printed out of box, need line change #1046

@lorancecall
Copy link

27dec57

On 'Overview' screen, right click of main and sub asset does not allow to create new asset type.

@fdoving
Copy link
Contributor Author

fdoving commented May 31, 2021

Units can only be increased after creation. 8 is max.
This should probably be shown somewhere.

@lsji07
Copy link
Contributor

lsji07 commented Nov 7, 2021

Using Windows 10 and Raven Core version v4.7.0.0-b5010492c (64-bit)

Spin boxes work correctly in my testing. Most asset spinboxes are limited to 21 billion as necessary and unique assets are 1 as expected.

Agree that additional cautionary comment/information is required close to the units spinbox to clarify. something like.

Caution: Reissuing an asset token can only increase the units and not reduce them in future. Use the minimum units your usecase requires currently.

I also had issues with the alert message printing out of box.
image

#1045 was also fixed for me on testing.

@m4r1m0
Copy link
Contributor

m4r1m0 commented Nov 29, 2021

Tested and works correctly on Ubuntu 20.04 using raven-4.7.0test3-b5010492c (64 bit)

Tested spin boxes on Main Asset, Restricted Asset, Sub Asset, Qualifier Asset, and Sub Qualifier Asset. Unique Assets and Message Channel Assets have a quantity restricted to 1.

Was able to successfully reissue assets and change the units, but not the quantity (as expected/intended).

The warning messages did clip on the GUI and I had to expand the window to read it. This should be fixed. When creating the qualifier I initially forgot the "#" and could not read the warning reminding me to include it.

@fdoving
Copy link
Contributor Author

fdoving commented Nov 29, 2021

Thanks for testing. I think we should create a new issue wrt. the warning message.

@fdoving
Copy link
Contributor Author

fdoving commented Nov 29, 2021

2x Confirmed working as expected. Closing as finished.

I think we should create a new issue wrt. the warning message.

@fdoving fdoving closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants