Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEUpgrade missing view method #150

Open
gabririgo opened this issue Nov 3, 2022 · 11 comments
Open

IEUpgrade missing view method #150

gabririgo opened this issue Nov 3, 2022 · 11 comments
Labels
bug Something isn't working contracts updates contracts folder

Comments

@gabririgo
Copy link
Contributor

IEUpgrade.sol is missing the getBeacon() method.

It would be useful adding it, however we must check to what extent the deterministic deployment would be affected.

@stale
Copy link

stale bot commented Dec 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@gabririgo
Copy link
Contributor Author

still relevant

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Jan 7, 2023
@gabririgo
Copy link
Contributor Author

still relevan

@stale
Copy link

stale bot commented Feb 18, 2023

This issue has been automatically closed because no activity occured in 30 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.

@stale stale bot closed this as completed Feb 18, 2023
@gabririgo gabririgo reopened this Feb 18, 2023
@stale stale bot removed the stale Stale issues label Feb 18, 2023
@stale
Copy link

stale bot commented Mar 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Mar 23, 2023
@stale
Copy link

stale bot commented Apr 25, 2023

This issue has been automatically closed because no activity occured in 30 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.

@stale stale bot closed this as completed Apr 25, 2023
@gabririgo gabririgo reopened this Apr 26, 2023
@stale stale bot removed the stale Stale issues label Apr 26, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Jun 10, 2023
@gabririgo gabririgo removed the stale Stale issues label Aug 7, 2023
@gabririgo gabririgo added the bug Something isn't working label Aug 30, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Oct 15, 2023
@gabririgo gabririgo added contracts updates contracts folder and removed stale Stale issues labels Oct 16, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Dec 15, 2023
@gabririgo gabririgo removed the stale Stale issues label Dec 15, 2023
@gabririgo
Copy link
Contributor Author

deployment will be affected, i.e. this will result in a different EUpgrade address. As this requires upgrading the EUpgrade extensions on all chains, which requires governance approval and does not bring any benefit as we already know what the beacon is, the benefit does not outweigh its related cost. The utility of public declaration of the getBeacon() method is to return the address of the contract providing the pool implementation address, which can be obtained by inspecting the contract directly on chain scanners, or by manually adding the method to the interface. We leave it open for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contracts updates contracts folder
Projects
None yet
Development

No branches or pull requests

1 participant