Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change of pool owner should not allow double voting #192

Open
gabririgo opened this issue Mar 1, 2023 · 6 comments
Open

test: change of pool owner should not allow double voting #192

gabririgo opened this issue Mar 1, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@gabririgo
Copy link
Contributor

This is currently now allowed by design as:

  1. pool operator cannot be changed in staking pool
  2. each pool's vote is stored, voting power is computed at sigle wallet/smart-wallet level and not aggregated level (i.e. pool operator).

However, we should develop a test to assert that a change in the pool operator won't affect ability to vote and won't allow double voting. This is relevant in the case we will query staking pool data from registry and pool, instead of initializing the staking pool, for gas efficiency (this will however affect ability to set staking pal, which is a feature which is not particularly requested anyway).

@stale
Copy link

stale bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Apr 2, 2023
@stale
Copy link

stale bot commented May 4, 2023

This issue has been automatically closed because no activity occured in 30 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.

@stale stale bot closed this as completed May 4, 2023
@gabririgo gabririgo reopened this May 4, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically closed because no activity occured in 30 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.

@stale stale bot closed this as completed Jun 10, 2023
@gabririgo gabririgo reopened this Jun 13, 2023
@stale stale bot removed the stale Stale issues label Jun 13, 2023
@stale
Copy link

stale bot commented Aug 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Aug 7, 2023
@gabririgo gabririgo removed the stale Stale issues label Aug 7, 2023
@gabririgo gabririgo added the enhancement New feature or request label Aug 30, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Oct 15, 2023
@gabririgo gabririgo removed the stale Stale issues label Oct 16, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Dec 15, 2023
@gabririgo gabririgo removed the stale Stale issues label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant