Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy initialization reentrancy #466

Closed
gabririgo opened this issue Mar 3, 2024 · 1 comment
Closed

fix: proxy initialization reentrancy #466

gabririgo opened this issue Mar 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@gabririgo
Copy link
Contributor

As described in this RBIP, a proxy initialization could be reentered. While side effects are unclear, it would be best to add a non-reentrancy modifier in the implementations.
Interestingly, this issue was never spotted by OpenZeppelin Defender.

@gabririgo gabririgo added the bug Something isn't working label Mar 3, 2024
@gabririgo gabririgo changed the title fix: proxy reentrancy fix: proxy initialization reentrancy Mar 3, 2024
@gabririgo
Copy link
Contributor Author

view methods to an external contract execute a staticcall and therefore pool initialization cannot be reentered in the context of rigoblock. Although adding a non-reentrant modifier would future-proof the proxy initialization, there is no apparent need for a non-view call to an external contract during pool initialization, therefore it is pointless to add gas cost to pool deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant