Videocamera Mirrors Flipped

[graysonk95]

I installed 2022.12 and noticed a potential bug with videocamera mirrors versus older versions. The mirrors are flipped horizontally in-game on any of my mods created in Blender and using Videocamera Mirrors. I've been away from the community for some years so maybe I've missed something, but I'm thinking this is a game bug versus a problem with my models.
Both my Thomas HDX and Freightliner FLA have this problem with mirrors, but they worked correctly in 0.38 and 0.4 versions of RoR.

I'm worried if I flip the texture on my model to fix the mirrors in 2022+, the mirrors will be wrong in <0.4. See screenshots.

0.4.0.7

2022.12

[ohlidalp]

@graysonk95 Great to see you around again!

Sorry about the response lag, I've been drowned in daily job lately.

Might easily be a bug, a lot went on with the materials and camera setup between 0.4x and now. I'll investigate, but no earlier than next weekend; in the meantime you can try mounting the basic left/right mirrors and see if the distortion remains.

[CuriousMike56]

The last version without this bug is 0.4.7.0, appears to have been introduced in early 0.4.8 RC builds. Possible solutions:

• Flip texture back to how it was in 0.4.7.0. This may affect newer mods.
• Add a new videocamera option to flip the texture on the affected mods.

[ohlidalp]

In addition to this, the classic mirror props are also broken, it becomes obvious when you flip the vehicle on a side.

I'm analyzing the code of both to figure something out.

[ohlidalp]

I looked in v0.4.0.7 source and the code which should flip it remained unchanged:

rigs-of-rods/source/main/physics/ActorSpawner.cpp

Lines 7077 to 7079 in 3816c27

	// this is a mirror, flip the image left<>right to have a mirror and not a cameraimage
	if (def->camera_role == 1)
	vcam.vcam_material->getTechnique(0)->getPass(0)->getTextureUnitState(0)->setTextureUScale(-1);

@paroj Is it possible the TextureUnitState::setTextureUScale() was broken? May it interfere with material cloning, texture switching or RTT?

[paroj]

try any other value there and see whether it makes a difference..

[ohlidalp]

@paroj Tried both positive and negative values, turns out OGRE works perfectly.

@graysonk95 I found the problem: both OGRE and RoR work as expected, but your mirror meshes have pre-flipped UVs because there used to be a bug somewhere. Screenshot from Blender:

Well, I'll add an option to unflip the mirror to the TopMenubar/Tuning menu.

[CuriousMike56]

The Mitsubishi Pajero also had flipped mirror UVs (fixed with update 1.3.1):