Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LogChannel class final #20

Open
KyNorthstar opened this issue Jan 31, 2022 · 0 comments
Open

Make LogChannel class final #20

KyNorthstar opened this issue Jan 31, 2022 · 0 comments
Labels
good first issue Good for newcomers
Milestone
1.0

Comments

@KyNorthstar
Copy link
Contributor

I don't see any reason to subclass it for the time being. If one comes up, making it non-final will be a non-breaking change. Best to do this before 1.0
@KyNorthstar KyNorthstar added the good first issue Good for newcomers label Jan 31, 2022
@KyNorthstar KyNorthstar added this to the 1.0 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@KyNorthstar