-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling #677
Comments
I do not think that just throttling errors is enough. We need to improve error handling in general. I tried to prototype automatic reconnection logic but currently it would look rather cumbersome, primarily because then we need an initialization function that re-creates the sources on-demand. |
Another related issue is that when I tried to avoid using standard output for messages I found that |
Another related thing to look at is real-time errors. For example we may not have any error messages or diagnostics if rodio's sources are too slow at producing samples. |
you bring up some good issues. Re-engineering error handling in rodio should be done at some point. For now I am going to focus on landing all the in progress and already planned work. Ill rename this to reflect your observations. |
needs: cpal to land so we can rate limit the printing of cpal errors. Will also allow us to implement
PartialEq
,Eq
&Hash
on our error types.The text was updated successfully, but these errors were encountered: