You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we should rename current_span_len() to samples_left_in_span() or something better. The current name sounds like the length is fixed, it can however be called at any time and then should returns the samples left until the resample rate and/or channel count can change. That is better communicated by having the word "left" in the name. Adding the word "samples" to the name makes it clear its not the number of frames.
Yes, It makes sense. Ideally this should be counted in frames, not samples, but that requires rewriting algorithms, including ones that users may already have...
I find code more readable when they are, but I do not know if there is consensus on that. Ill have to look into best practices for variable naming. If I find any we can make that a guideline for the project. Only if we both agree it of course.
we should rename
current_span_len()
tosamples_left_in_span()
or something better. The current name sounds like the length is fixed, it can however be called at any time and then should returns the samples left until the resample rate and/or channel count can change. That is better communicated by having the word "left" in the name. Adding the word "samples" to the name makes it clear its not the number of frames.Originally posted by @dvdsk in #684 (comment)
The text was updated successfully, but these errors were encountered: