From 71b625a06ee94962728bfd4a3d9fb7bfb1b3b707 Mon Sep 17 00:00:00 2001 From: Sambit Chakraborty Date: Sat, 18 Jan 2025 00:08:50 +0530 Subject: [PATCH] Update: Code conventions for PHP 8.x & Update: .gitignore to include composer.lock (in support of PR #2722 : Autoload) --- .gitignore | 1 + src/PhpWord/IOFactory.php | 2 +- src/PhpWord/Writer/{ePub3.php => EPub3.php} | 13 ++++++------- .../{ePub3 => EPub3}/Part/AbstractPart.php | 9 +++++---- .../Writer/{ePub3 => EPub3}/Part/Content.php | 7 ++++--- .../Writer/{ePub3 => EPub3}/Part/Manifest.php | 5 +++-- .../Writer/{ePub3 => EPub3}/Part/Meta.php | 7 ++++--- .../Writer/{ePub3 => EPub3}/Part/Mimetype.php | 5 +++-- .../{ePub3 => EPub3}/Style/AbstractStyle.php | 9 +++++---- .../Writer/{ePub3 => EPub3}/Style/Font.php | 5 +++-- .../Writer/{ePub3 => EPub3}/Style/Paragraph.php | 5 +++-- .../Writer/{ePub3 => EPub3}/Style/Table.php | 5 +++-- .../Writer/{ePub3Test.php => EPub3Test.php} | 17 +++++++++-------- 13 files changed, 50 insertions(+), 40 deletions(-) rename src/PhpWord/Writer/{ePub3.php => EPub3.php} (88%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Part/AbstractPart.php (86%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Part/Content.php (90%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Part/Manifest.php (93%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Part/Meta.php (89%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Part/Mimetype.php (91%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Style/AbstractStyle.php (86%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Style/Font.php (92%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Style/Paragraph.php (92%) rename src/PhpWord/Writer/{ePub3 => EPub3}/Style/Table.php (93%) rename tests/PhpWordTests/Writer/{ePub3Test.php => EPub3Test.php} (92%) diff --git a/.gitignore b/.gitignore index 0b9d0608d0..6918df72e6 100644 --- a/.gitignore +++ b/.gitignore @@ -12,6 +12,7 @@ _build /build phpunit.xml composer.phar +composer.lock vendor /report /build diff --git a/src/PhpWord/IOFactory.php b/src/PhpWord/IOFactory.php index 5325dbf4b3..50c419cae2 100644 --- a/src/PhpWord/IOFactory.php +++ b/src/PhpWord/IOFactory.php @@ -36,7 +36,7 @@ abstract class IOFactory */ public static function createWriter(PhpWord $phpWord, $name = 'Word2007') { - if ($name !== 'WriterInterface' && !in_array($name, ['ODText', 'RTF', 'Word2007', 'HTML', 'PDF', 'EPUB'], true)) { + if ($name !== 'WriterInterface' && !in_array($name, ['ODText', 'RTF', 'Word2007', 'HTML', 'PDF', 'EPub3'], true)) { throw new Exception("\"{$name}\" is not a valid writer."); } diff --git a/src/PhpWord/Writer/ePub3.php b/src/PhpWord/Writer/EPub3.php similarity index 88% rename from src/PhpWord/Writer/ePub3.php rename to src/PhpWord/Writer/EPub3.php index d273017118..b9eb5a00f2 100644 --- a/src/PhpWord/Writer/ePub3.php +++ b/src/PhpWord/Writer/EPub3.php @@ -1,4 +1,5 @@ parts) as $partName) { $partClass = static::class . '\\Part\\' . $partName; if (class_exists($partClass)) { - /** @var \PhpOffice\PhpWord\Writer\ePub3\Part\AbstractPart $partObject Type hint */ + /** @var AbstractPart $partObject Type hint */ $partObject = new $partClass(); $partObject->setParentWriter($this); $this->writerParts[strtolower($partName)] = $partObject; diff --git a/src/PhpWord/Writer/ePub3/Part/AbstractPart.php b/src/PhpWord/Writer/EPub3/Part/AbstractPart.php similarity index 86% rename from src/PhpWord/Writer/ePub3/Part/AbstractPart.php rename to src/PhpWord/Writer/EPub3/Part/AbstractPart.php index 25f5c930fd..c3b79b2d26 100644 --- a/src/PhpWord/Writer/ePub3/Part/AbstractPart.php +++ b/src/PhpWord/Writer/EPub3/Part/AbstractPart.php @@ -1,4 +1,5 @@ '; $content .= ''; $content .= ''; - $content .= 'Sample ePub3 Document'; + $content .= 'Sample EPub3 Document'; $content .= 'en'; $content .= ''; $content .= ''; diff --git a/src/PhpWord/Writer/ePub3/Part/Manifest.php b/src/PhpWord/Writer/EPub3/Part/Manifest.php similarity index 93% rename from src/PhpWord/Writer/ePub3/Part/Manifest.php rename to src/PhpWord/Writer/EPub3/Part/Manifest.php index cad39b1db4..9c5143f434 100644 --- a/src/PhpWord/Writer/ePub3/Part/Manifest.php +++ b/src/PhpWord/Writer/EPub3/Part/Manifest.php @@ -1,4 +1,5 @@ '; $content .= ''; - $content .= 'Sample ePub3 Document'; + $content .= 'Sample EPub3 Document'; $content .= 'en'; $content .= 'urn:uuid:12345'; $content .= '2023-01-01T00:00:00Z'; diff --git a/src/PhpWord/Writer/ePub3/Part/Mimetype.php b/src/PhpWord/Writer/EPub3/Part/Mimetype.php similarity index 91% rename from src/PhpWord/Writer/ePub3/Part/Mimetype.php rename to src/PhpWord/Writer/EPub3/Part/Mimetype.php index 48251d2749..36dc9168b1 100644 --- a/src/PhpWord/Writer/ePub3/Part/Mimetype.php +++ b/src/PhpWord/Writer/EPub3/Part/Mimetype.php @@ -1,4 +1,5 @@ getPhpWord()); self::assertEquals('./', $object->getDiskCachingDirectory()); foreach (['Content', 'Manifest', 'Mimetype'] as $part) { @@ -55,7 +56,7 @@ public function testConstructWithNull(): void { $this->expectException(\PhpOffice\PhpWord\Exception\Exception::class); $this->expectExceptionMessage('No PhpWord assigned.'); - $object = new ePub3(); + $object = new EPub3(); $object->getPhpWord(); } @@ -76,7 +77,7 @@ public function testSave(): void $section->addTitle('Test', 1); $section->addPageBreak(); $section->addImage($imageSrc); - $writer = new ePub3($phpWord); + $writer = new EPub3($phpWord); $writer->save($file); self::assertFileExists($file); unlink($file); @@ -90,7 +91,7 @@ public function testSavePhpOutput(): void $phpWord = new PhpWord(); $section = $phpWord->addSection(); $section->addText('Test'); - $writer = new ePub3($phpWord); + $writer = new EPub3($phpWord); ob_start(); $writer->save('php://output'); $contents = ob_get_contents(); @@ -103,7 +104,7 @@ public function testSavePhpOutput(): void */ public function testSetGetUseDiskCaching(): void { - $object = new ePub3(); + $object = new EPub3(); $object->setUseDiskCaching(true, PHPWORD_TESTS_BASE_DIR); self::assertTrue($object->isUseDiskCaching()); self::assertEquals(PHPWORD_TESTS_BASE_DIR, $object->getDiskCachingDirectory()); @@ -117,7 +118,7 @@ public function testSetUseDiskCachingException(): void $this->expectException(\PhpOffice\PhpWord\Exception\Exception::class); $dir = implode(DIRECTORY_SEPARATOR, [PHPWORD_TESTS_BASE_DIR, 'foo']); - $object = new ePub3(); + $object = new EPub3(); $object->setUseDiskCaching(true, $dir); } }