Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SponsorsTable): add gadfly #586

Merged
merged 6 commits into from
Feb 4, 2025
Merged

feat(SponsorsTable): add gadfly #586

merged 6 commits into from
Feb 4, 2025

Conversation

Readpato
Copy link
Member

@Readpato Readpato commented Feb 4, 2025

As title says

@Readpato Readpato added the Site New feature or request for the site label Feb 4, 2025
@Readpato Readpato self-assigned this Feb 4, 2025
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for keen-banoffee-86ed50 ready!

Name Link
🔨 Latest commit c5f97d3
🔍 Latest deploy log https://app.netlify.com/sites/keen-banoffee-86ed50/deploys/67a2425854eb670008d585e2
😎 Deploy Preview https://deploy-preview-586--keen-banoffee-86ed50.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TheJoin95
TheJoin95 previously approved these changes Feb 4, 2025
@TheJoin95
Copy link
Member

btw we have the sponsor section two time: one at the top and one just before the footer

@Readpato
Copy link
Member Author

Readpato commented Feb 4, 2025

Ah, good catch @TheJoin95! I will remove it before merging this one :)

TheJoin95
TheJoin95 previously approved these changes Feb 4, 2025
TheJoin95
TheJoin95 previously approved these changes Feb 4, 2025
@Readpato
Copy link
Member Author

Readpato commented Feb 4, 2025

So... a PR that should have been a one liner, ended up being a whole rewrite lol

I think this was needed because there where some comments left over from past versions that were cluttering the boilerplate and the sponsors where added one by one instead of creating a loop to render them.

Let me know what you think, the PR is mostly deletions. Also, any React feedback that you have on this will be greatly appreciated :)

@TheJoin95
Copy link
Member

It's okay Pato, we need a new website for OSDay, let's just do the job for this edition then we'll see for the next one

@Readpato Readpato merged commit 394c0c4 into 2025 Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site New feature or request for the site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants