Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings, Keybinds, and Keybord-Nav UI Version 3 #266

Merged
merged 111 commits into from
Sep 18, 2022
Merged

Settings, Keybinds, and Keybord-Nav UI Version 3 #266

merged 111 commits into from
Sep 18, 2022

Conversation

Jemoka
Copy link
Member

@Jemoka Jemoka commented Aug 6, 2022 •
edited
Loading

image

image

image

Settings page, keybind editor, 1.2.0 booya!

99.978% of the credit goes to @TheEnquirer as the engineering manager (and engineer and tester and developer) on this release.

Closes #55
Closes #160
Closes #247
Closes #105
Closes #264

@TheEnquirer
initialize the settings page
3cf29ed 
i'm back, baby!!
@TheEnquirer
settings general layout
236dc76
@TheEnquirer
quick esc button
f0fa8f0
@TheEnquirer
esc button!
507154c
@TheEnquirer
bundle indexing
5c44234
@TheEnquirer
sdebar stylin
44d18d9
@TheEnquirer
titleing
e8d2dba
@TheEnquirer
some themeing
ed7f3a9
@TheEnquirer
a justfile :)
832fc2a
@TheEnquirer
delete :W
09bfe30 
we don't need that file!
@TheEnquirer
move to function syntax and pass in state setters for bundles
5f8a2c5
@TheEnquirer
update the way we pass in states for setting bundles
837fe8a
@TheEnquirer
add change log in settings page
5e87c7a
@TheEnquirer
NW: update tags page to conditionally work as non modal
e411c16
@TheEnquirer
allow the tag editor to be non-modal and insert it into settings page
5c7d621 
bug: for some reason, the tags only load sometimes?
@TheEnquirer
fix the tags not loading bug
1884ab8
@TheEnquirer
minor css changes
8110813
@TheEnquirer
starting the account page
358cdd3
@TheEnquirer
sync for arch
75307e6
@TheEnquirer
indent!
283b6dc
@TheEnquirer
indent pt2!
bc4758d
@TheEnquirer
keybind inits
9f47744
@TheEnquirer
keybinds
5ef0947
@TheEnquirer
keybind handler and manager functions init
85422d9
@TheEnquirer
keybind handler cross platform migration
6a4050d
@TheEnquirer
move the keybind handler to its own file and clean the code
805214f
@TheEnquirer
delete prject, complete project, and select things with keybinds!
c1c6e07
@TheEnquirer
up and down select
edd548e
@TheEnquirer
give up on coords :((
ea5907e
@TheEnquirer
opening, completing, ect
0ecec03
@zbuster05 zbuster05 requested review from zbuster05 and a team September 12, 2022 04:48
@TheEnquirer TheEnquirer temporarily deployed to s3-access September 12, 2022 07:46 Inactive
@TheEnquirer TheEnquirer temporarily deployed to s3-access September 12, 2022 16:57 Inactive
@TheEnquirer TheEnquirer temporarily deployed to s3-access September 12, 2022 17:05 Inactive
@FlyN-Nick
Copy link
Member

Thank you for making the fixes @TheEnquirer
don't allow repeat keys inside the keybinds and @TheEnquirer
max keybind len w/ no overflow.

Love the polish and UI!

@TheEnquirer
change cmd pallete launch to be part of keybinding ecosystem
008ea12 
+ bugfix the cmd-{x} keybind for launching cmdp breaking
@TheEnquirer TheEnquirer temporarily deployed to s3-access September 12, 2022 21:34 Inactive
@TheEnquirer TheEnquirer temporarily deployed to s3-access September 12, 2022 21:46 Inactive
@TheEnquirer TheEnquirer temporarily deployed to s3-access September 12, 2022 23:06 Inactive
@TheEnquirer TheEnquirer temporarily deployed to s3-access September 15, 2022 05:24 Inactive
Jemoka
Jemoka commented Sep 15, 2022
View reviewed changes
Copy link
Member Author

@Jemoka Jemoka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the alternative to the command pallet command again now with removal? Sorry for the ping

Exr0n
Exr0n previously approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@Exr0n Exr0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes?

@Jemoka Jemoka temporarily deployed to s3-access September 18, 2022 04:59 Inactive
TheEnquirer
TheEnquirer approved these changes Sep 18, 2022
View reviewed changes
Copy link
Collaborator

@TheEnquirer TheEnquirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah.

@Jemoka Jemoka requested a review from FlyN-Nick September 18, 2022 05:11
FlyN-Nick
FlyN-Nick approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@FlyN-Nick FlyN-Nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no more bugs, looks good!

@Jemoka Jemoka merged commit f138fd6 into beta-v1.2.0 Sep 18, 2022
@Jemoka Jemoka deleted the feat-settingsv3 branch September 18, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbuster05 zbuster05 zbuster05 left review comments

@FlyN-Nick FlyN-Nick FlyN-Nick approved these changes

@TheEnquirer TheEnquirer TheEnquirer approved these changes

@Exr0n Exr0n Exr0n left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Jemoka @FlyN-Nick @Exr0n @zbuster05 @TheEnquirer