Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Faceted Filters] Clear controls do not manage focus #109

Open
svinkle opened this issue Jul 6, 2021 · 0 comments
Open

[Faceted Filters] Clear controls do not manage focus #109

svinkle opened this issue Jul 6, 2021 · 0 comments
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Critical Path: 1 Affects all merchants/buyers Effort: Medium Severity: 2 High Severity

Comments

@svinkle
Copy link
Member

svinkle commented Jul 6, 2021

Issue summary

When using the facet clear controls, keyboard focus is not managed on behalf of the user. When a clear control is activated focus is lost and, depending on the environment, could be placed at the top of the DOM. As a result, users may need to navigate back to where they were previously. Some sighted AT user groups may be confused when the focus indicator disappears as a result.

Screenshots

Gif of Dawn facet clear controls. Clear control is activated, focus is lost. Shrugging emoji appears.

Steps to reproduce

  1. Go to a collection page with Dawn theme with any supported browser.
  2. Navigate to and activate a Facet Filter control.
  3. Activate a facet.
  4. Navigate to the facet close control and activate.

Behavior

Expected

  • Focus to shift to a logical place in order for AT users to understand where focus is and where to start navigating from.

Actual

  • Keyboard focus is lost.

Recommendation

On Desktop:

  1. If only one facet is active, shift focus to the "Filter by" heading. Add tabindex="-1" to the heading in order for it to receive focus.
  2. If more than one facet is active, shift focus to next filter link.

On Mobile:

  1. If only one facet is active, shift focus to the "Filter and sort" control.
  2. If more than one facet is active, shift focus to next filter link.

With this in place, keyboard-only users and screen reader users will have focus set back to a logical start position providing a mechanism to continue navigating from this point. Other sighted AT users (such as voice dictation) will have an understanding of the current keyboard cursor position.

Recommended code

Specifications

  • Component: Faceted Filters
  • WCAG Principal: Operable
  • WCAG SC: 2.1.1 Keyboard
  • Severity: Medium
  • Effort: Medium
@svinkle svinkle added Severity: 3 Normal/Low Severity Category: Bug Something isn't working Category: Accessibility Bugs found while using assistive technology labels Jul 6, 2021
@svinkle svinkle added the Critical Path: 1 Affects all merchants/buyers label Nov 26, 2021
@svinkle svinkle added Severity: 2 High Severity and removed Severity: 3 Normal/Low Severity labels Mar 3, 2022
@svinkle svinkle mentioned this issue Mar 22, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Critical Path: 1 Affects all merchants/buyers Effort: Medium Severity: 2 High Severity
Projects
None yet
Development

No branches or pull requests

1 participant