Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Faceted Filters] Mobile close control missing accessible name #117

Open
svinkle opened this issue Jul 6, 2021 · 0 comments
Open

[Faceted Filters] Mobile close control missing accessible name #117

svinkle opened this issue Jul 6, 2021 · 0 comments
Assignees
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Critical Path: 1 Affects all merchants/buyers Effort: Low Severity: 2 High Severity

Comments

@svinkle
Copy link
Member

svinkle commented Jul 6, 2021

Issue summary

When the Facet window is open while using a mobile screen reader, the Close control is missing its accessible name/alternative text. When focused, screen readers will announce the control type and state only. This may create a confusing user experience when the control purpose os not provided.

Screenshots Screen shot of mobile faceted filters section. Close control is highlighted.

Current code

HTML

<span tabindex="0" class="mobile-facets__close mobile-facets__close--no-js">
  <!-- SVG… -->
</span>

Steps to reproduce

  1. Go to a collection page with Dawn theme with any supported mobile browser.
  2. Activate the "Filter and Sort" control.
  3. With an active screen reader, navigate to the Close control.

Behavior

Expected

  • Controls to feature an accessible name for assistive technology.

Actual

  • Close control is missing its accessible name.

Recommendation

Adjust the CSS to not hide the .mobile-facets__open container which houses the control accessible name.

Recommended code

CSS

details[open] .mobile-facets__open {
  /* visibility: hidden; */
}

Specifications

@svinkle svinkle added Severity: 2 High Severity Category: Bug Something isn't working Category: Accessibility Bugs found while using assistive technology labels Jul 6, 2021
@svinkle svinkle added the Critical Path: 1 Affects all merchants/buyers label Nov 26, 2021
@ludoboludo ludoboludo self-assigned this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Critical Path: 1 Affects all merchants/buyers Effort: Low Severity: 2 High Severity
Projects
None yet
Development

No branches or pull requests

2 participants