Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Faceted Filters] Reset link purpose may not be clear #121

Open
svinkle opened this issue Jul 6, 2021 · 0 comments
Open

[Faceted Filters] Reset link purpose may not be clear #121

svinkle opened this issue Jul 6, 2021 · 0 comments
Labels
Category: Accessibility Bugs found while using assistive technology Category: Enhancement New feature or request Critical Path: 1 Affects all merchants/buyers Effort: Low Severity: 3 Normal/Low Severity

Comments

@svinkle
Copy link
Member

svinkle commented Jul 6, 2021

Issue summary

When a screen reader user encounters a Reset link, the purpose of the link may not be clear out of context. Screen reader software features the ability to navigate by only a specified element type. This could lead to a confusing user experience without more information.

Screenshots Screen shot of faceted filters section. Brand facet is expanded, Reset link is highlighted.

Current code

HTML

<a
  href="/collections/all?sort_by=created-descending"
  class="facets__reset link underlined-link js-facet-remove"
>
  Reset
</a>

Steps to reproduce

  1. Go to a collection page with Dawn theme with any supported browser.
  2. Activate a facet filter control.
  3. With an active screen reader, navigate to the Reset link.

Behavior

Expected

  • Reset link to have additional information for context.

Actual

  • Reset link does not feature additional context.

Recommendation

  1. Add a unique id for each summary control.
  2. Add the aria-describedby attribute to each Reset link, setting its value to match the id of its respective facet control.

With this, the Reset links will feature more context for its purpose. For example, this Size related Reset link will be announced as, "Reset, link, Size".

Recommended code

HTML

<summary class="facets__summary"  id="FacetsSummary-0">
  <!-- … -->
  <span>Size</span>
  <span class="count-bubble"></span>
  <!-- … -->
</summary>

<!-- … -->

<a
  href="/collections/all?sort_by=created-descending"
  class="facets__reset link underlined-link js-facet-remove"
  aria-describedby="FacetsSummary-0"
>
  Reset
</a>

Specifications

@svinkle svinkle added Severity: 3 Normal/Low Severity Category: Enhancement New feature or request Category: Accessibility Bugs found while using assistive technology labels Jul 6, 2021
@svinkle svinkle added the Critical Path: 1 Affects all merchants/buyers label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Category: Enhancement New feature or request Critical Path: 1 Affects all merchants/buyers Effort: Low Severity: 3 Normal/Low Severity
Projects
None yet
Development

No branches or pull requests

1 participant