Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section Translation documentation update #159

Open
austinhutchison opened this issue Jul 9, 2021 · 0 comments
Open

Section Translation documentation update #159

austinhutchison opened this issue Jul 9, 2021 · 0 comments

Comments

@austinhutchison
Copy link

austinhutchison commented Jul 9, 2021

Describe the enhancement you'd like
I was unfamiliar with localization markup within {% schema %} tags and it is used throughout the Dawn sections (e.g. "name": "t:sections.main-product.name") . I'm still unsure how the t: markup really works.

I'd like to see better documentation of the localization in the sections documentation here: https://shopify.dev/themes/architecture/sections/section-schema#locales and for the examples to reference how Dawn approaches localization.

Please let me know if this documentation is located elsewhere and I just wasn't able to find it. (google-fu doesn't play so nicely with colons 😔)

Describe alternatives you've considered
I would also consider updating the readme to include a statement regarding Dawns approach to localization. Many developers won't have the need or resources to build out locale files for new sections and it would be nice to recognize that Dawn is maybe not the best example or at least won't reflect lots of real world use cases in this regard.

Additional context/screenshots
n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant