Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Cards: Slight position shift on hover zoom #9

Open
2 tasks
nicklepine opened this issue Jun 25, 2021 · 3 comments
Open
2 tasks

Product Cards: Slight position shift on hover zoom #9

nicklepine opened this issue Jun 25, 2021 · 3 comments
Assignees
Labels
Category: Bug Something isn't working Severity: 3 Normal/Low Severity

Comments

@nicklepine
Copy link

nicklepine commented Jun 25, 2021

Problems

  • There is a bit of position shift with the zoom animation on hover of images on product cards: video

  • A slight blur also occurs when hovering off

Adding will-change: transform; to the image solves the shift

@nicklepine nicklepine added Category: Bug Something isn't working Severity: 2 High Severity labels Jun 25, 2021
@nicklepine
Copy link
Author

nicklepine commented Jun 25, 2021

Note from @sofiamatulis

Note: will-change should not be overused, otherwise it may hurt performance. More here: https://developer.mozilla.org/en-US/docs/Web/CSS/will-change

This may fix this issue in regard to the flickering: https://screenshot.click/15-18-kf5n8-phqgf-TS.mp4

https://shopify.slack.com/archives/CB0JT58RE/p1623716413307100

For the blur, we may be able to leverage this: https://usefulangle.com/post/307/css-transform-scale-preserve-image-quality

However, it will all depend on the quality of the image the merchant used. If we are zooming in in a low quality image, it will be more blurry

@nicklepine nicklepine added Severity: 3 Normal/Low Severity and removed Severity: 2 High Severity labels Sep 2, 2021
@kimberlyoleiro
Copy link

This looks to be solved with the newest animation work. @ludoboludo could you please triple-check for me and close this ticket?

@ludoboludo
Copy link
Contributor

Still a thing from what I can see 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working Severity: 3 Normal/Low Severity
Projects
None yet
Development

No branches or pull requests

3 participants