We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems
There is a bit of position shift with the zoom animation on hover of images on product cards: video
A slight blur also occurs when hovering off
Adding will-change: transform; to the image solves the shift
will-change: transform;
The text was updated successfully, but these errors were encountered:
Note from @sofiamatulis
Note: will-change should not be overused, otherwise it may hurt performance. More here: https://developer.mozilla.org/en-US/docs/Web/CSS/will-change This may fix this issue in regard to the flickering: https://screenshot.click/15-18-kf5n8-phqgf-TS.mp4 https://shopify.slack.com/archives/CB0JT58RE/p1623716413307100 For the blur, we may be able to leverage this: https://usefulangle.com/post/307/css-transform-scale-preserve-image-quality However, it will all depend on the quality of the image the merchant used. If we are zooming in in a low quality image, it will be more blurry
Note: will-change should not be overused, otherwise it may hurt performance. More here: https://developer.mozilla.org/en-US/docs/Web/CSS/will-change
This may fix this issue in regard to the flickering: https://screenshot.click/15-18-kf5n8-phqgf-TS.mp4
https://shopify.slack.com/archives/CB0JT58RE/p1623716413307100
For the blur, we may be able to leverage this: https://usefulangle.com/post/307/css-transform-scale-preserve-image-quality
However, it will all depend on the quality of the image the merchant used. If we are zooming in in a low quality image, it will be more blurry
Sorry, something went wrong.
This looks to be solved with the newest animation work. @ludoboludo could you please triple-check for me and close this ticket?
Still a thing from what I can see 👍
ludoboludo
No branches or pull requests
Problems
There is a bit of position shift with the zoom animation on hover of images on product cards: video
A slight blur also occurs when hovering off
Adding
will-change: transform;
to the image solves the shiftThe text was updated successfully, but these errors were encountered: