Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

[tests] FakeFS not used for project_types/script/commands/create_test.rb #940

Closed
andyw8 opened this issue Oct 28, 2020 · 1 comment · Fixed by #942
Closed

[tests] FakeFS not used for project_types/script/commands/create_test.rb #940

andyw8 opened this issue Oct 28, 2020 · 1 comment · Fixed by #942

Comments

@andyw8
Copy link
Contributor

andyw8 commented Oct 28, 2020 •
edited
Loading

Issue summary

While investigating some intermittently failing tests, I discovered that this test's setup method doesn't call super, meaning the FakeFS setup isn't called:

https://github.com/Shopify/shopify-app-cli/blob/dcfccb5a8d5808477a15ab16e6477d396e818ea7/test/project_types/script/commands/create_test.rb#L10-L12

Adding in the call to super causes some new failures which I'm still looking into.
@andyw8
Copy link
Contributor Author

andyw8 commented Oct 28, 2020

Maybe rubocop should catch this automatically: rubocop/rubocop-minitest#111

This was referenced Oct 28, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tests] Fix use of FakeFS Shopify/shopify-cli
1 participant
@andyw8