Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fontawsome needed #461

Closed
casvos opened this issue Feb 5, 2019 · 8 comments
Closed

Support for fontawsome needed #461

casvos opened this issue Feb 5, 2019 · 8 comments

Comments

@casvos
Copy link

casvos commented Feb 5, 2019

I use special icons in my present website and would like to use it in Simplero as well, both in text and Buttons etc.

Any thought about making this happen in the near future?

https://fontawesome.com

@calvincorreli
Copy link
Contributor

I believe you should be able to add this by editing your site theme's code. Just add the LINK tag to your layout/theme.liquid file.

https://fontawesome.com/start

I don't think it's something we want to add to all sites by default.

@casvos
Copy link
Author

casvos commented Feb 6, 2019 via email

@calvincorreli
Copy link
Contributor

calvincorreli commented Feb 6, 2019

It looks like you're closing the <i> tag with something other than </i>.

Is it a lowercase "L"? It needs to be the same thing.

@casvos
Copy link
Author

casvos commented Feb 6, 2019 via email

@calvincorreli
Copy link
Contributor

Send me a link to the page, please.

@casvos
Copy link
Author

casvos commented Feb 7, 2019 via email

@calvincorreli
Copy link
Contributor

I see. The TinyMCE editor is a little aggressive in replacing i tags with em tags, and then removing empty em tags.

This is a work-around that gets the job done:

<span class="fas fa-igloo">​&#8203;</span>

It uses the span tag option, and then includes a "zero-width space" so that TinyMCE won't remove it.

@casvos
Copy link
Author

casvos commented Feb 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants