Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final to onSuccess and onFail function in LambdaResponseHandler #193

Open
carmenlau opened this issue Jan 26, 2018 · 2 comments
Open

Add final to onSuccess and onFail function in LambdaResponseHandler #193

carmenlau opened this issue Jan 26, 2018 · 2 comments
Labels
type/minor-improvement vote/2

Comments

@carmenlau
Copy link
Contributor

Calvin's comment, if we don't expect user to override onSuccess and onFail in LambdaResponseHandler. Should make them finial to avoid confusion.
@hidden-dimensions
Copy link

Also AuthResponseHandler, LogoutResponseHandler and probably other

@carmenlau carmenlau added vote/2 and removed vote/1 labels Jun 21, 2018
@carmenlau
Copy link
Contributor Author

Also RecordSaveResponseHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/minor-improvement vote/2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carmenlau @hidden-dimensions