Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKYAsset.h and SKYAsset_Private.h both contain url make ref count wrong #136

Open
rickmak opened this issue Oct 13, 2017 · 0 comments
Open
Assignees
Labels

Comments

@rickmak
Copy link
Member

rickmak commented Oct 13, 2017

@howawong run into a nil pointer exception after called copy method on SKYAsset. the nil point is on @property (nonatomic, readwrite, copy) NSURL *url;.

To fix the mis-behaviour, we just delete the @property (nonatomic, readwrite, copy) NSURL *url; at SKYAsset_Private.h.

Our guess is the redefine of attribute in both SKYAsset.h and SKYAsset_Private.h hit a compiler bug. But we are still lack of minimal test project to demo this. I think at least @howawong can push the crashing code in some brach for diagnosis.

This issue is to identify and confirm the issue. Make sure other *_Private.h in our project don't repeat the mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants