Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[invader-bitmap/invader-sound] Warn if multiple valid inputs are present and -P isn't used #207

Open
SnowyMouse opened this issue May 20, 2021 · 3 comments

Comments

@SnowyMouse
Copy link
Owner

If a FLAC and a WAV have the same basename or if a TIFF and a PNG (or a BMP, etc.) are present, it should warn because you may not be getting the desired output.

@SnowyMouse
Copy link
Owner Author

Here are a couple of examples:

  • If I have a test.tif AND test.tiff present in the same folder and I try to make test.bitmap, it should warn, but use the tif by default since that's what tool.exe uses.
  • If I have a test.wav AND test.flac present in the same folder and I try to make a sound tag with it, it should warn, but use wav by default since that's what tool.exe uses.

@Aerocatia
Copy link
Collaborator

This would be nice but it means querying the fs for each supported file type. Would that not have somewhat of a performance impact?

@SnowyMouse
Copy link
Owner Author

For sounds, no, as we already do this to get all the permutations.

For bitmaps, yes, though it probably isn't very much, and we need to be consistent. We do this with shaders when compiling models, anyway.

@SnowyMouse SnowyMouse added this to the Complete Editing Kit milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants