Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Decide whether or not to keep ITestProjectIndicator #4772

Open
duncanp-sonar opened this issue Aug 23, 2023 · 0 comments
Open

[Cleanup] Decide whether or not to keep ITestProjectIndicator #4772

duncanp-sonar opened this issue Aug 23, 2023 · 0 comments

Comments

@duncanp-sonar
Copy link
Contributor

duncanp-sonar commented Aug 23, 2023

Description

Previously, the old Connected Mode binding filtered out test projects during binding i.e. it would not add settings to a project file if it was a test project. The new unintrusive binding logic doesn't change project files so this logic is no longer called.

The logic for determining whether a project is a test project or not is reasonably complicated: see this Sonar Scanner for .NET wiki page for more information. The SLVS logic should be the same as the Scanner logic.

The test-detection logic is not currently used in SLVS i.e. test code is treated exactly the same as product code, whereas the Sonar scanners do differentiate between test and product code.

If the intention is to make SLVS handle test code differently then the ITestProjectIndicator code would be useful. Otherwise, it can be deleted.

TODO - decide whether to keep the ITestProjectIndicator and implementations.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant