Fix #646: Upgrade electron to 27.0.3 #1035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #646
Context / Background
Updating electron to a newer version than 12 :)
What change is being introduced by this PR?
require()
statements would stop working.@electron/remote
. This requires initialization in main process, which for renderer tests is done in the jest rpc patch.electron-store
package v6 stopped working because it required the old remote. Upgrade to latest, which now requires an initialization step in main just like above.sender
member in our tests, which went away. Had to remove the line in the tests.How will this be tested?
Ran the app locally, all tests are also passing.
Also testing the release flow in https://github.com/araujoarthur0/time-to-leave/actions/runs/6745696311